On Tue, 7 Jun 2022 20:31:32 +0200, Stephen Kitt <st...@sk2.org> wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h.
Apologies for the misleading boilerplate, this patch came about as a result of cleaning up fb_blank usage but doesn't involve fb_blank itself. > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt <st...@sk2.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c index > f6628a5ee95f..794573badfe8 100644 --- > a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c +++ > b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c @@ -18,11 +18,7 @@ static > int shmob_drm_backlight_update(struct backlight_device *bdev) struct > shmob_drm_connector *scon = bl_get_data(bdev); struct shmob_drm_device > *sdev = scon->connector.dev->dev_private; const struct > shmob_drm_backlight_data *bdata = &sdev->pdata->backlight; > - int brightness = bdev->props.brightness; > - > - if (bdev->props.power != FB_BLANK_UNBLANK || > - bdev->props.state & BL_CORE_SUSPENDED) > - brightness = 0; > + int brightness = backlight_get_brightness(bdev); > > return bdata->set_brightness(brightness); > } > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 > -- > 2.30.2 >
pgpOJsUpNezJt.pgp
Description: OpenPGP digital signature
