On Thu, 2022-05-19 at 16:37 +0000, Sean Christopherson wrote:
> On Wed, Apr 27, 2022, Maxim Levitsky wrote:
> > @@ -5753,6 +5752,10 @@ int kvm_mmu_init_vm(struct kvm *kvm)
> > node->track_write = kvm_mmu_pte_write;
> > node->track_flush_slot = kvm_mmu_invalidate_zap_pages_in_memslot;
> > kvm_page_track_register_notifier(kvm, node);
>
> Can you add a patch to move this call to kvm_page_track_register_notifier()
> into
> mmu_enable_write_tracking(), and simultaneously add a WARN in the register
> path
> that page tracking is enabled?
>
> Oh, actually, a better idea. Add an inner __kvm_page_track_register_notifier()
> that is not exported and thus used only by KVM, invoke
> mmu_enable_write_tracking()
> from the exported kvm_page_track_register_notifier(), and then do the above.
> That will require modifying KVMGT and KVM in a single patch, but that's ok.
>
> That will avoid any possibility of an external user failing to enabling
> tracking
> before registering its notifier, and also avoids bikeshedding over what to do
> with
> the one-line wrapper to enable tracking.
>
This is a good idea as well, especially looking at kvmgt and seeing that
it registers the page track notifier, when the vGPU is opened.
I'll do this in the next series.
Thanks for the review!
Best regards,
Maxim Levitsky
