From: Zack Rusin <za...@vmware.com>

Switch to using the TTM resource manager debugfs helpers. It's
exactly the same functionality, except that the entries live under
/sys/kernel/debug/ttm/.

Signed-off-by: Zack Rusin <za...@vmware.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Cc: "Christian König" <christian.koe...@amd.com>
Cc: "Pan, Xinhui" <xinhui....@amd.com>
Cc: David Airlie <airl...@linux.ie>
Cc: Daniel Vetter <dan...@ffwll.ch>
Cc: Felix Kuehling <felix.kuehl...@amd.com>
Cc: Nirmoy Das <nirmoy....@amd.com>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: amd-...@lists.freedesktop.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 81 ++++---------------------
 1 file changed, 11 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 57ac118fc266..9852a11a5758 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2079,17 +2079,6 @@ int amdgpu_ttm_evict_resources(struct amdgpu_device 
*adev, int mem_type)
 
 #if defined(CONFIG_DEBUG_FS)
 
-static int amdgpu_mm_vram_table_show(struct seq_file *m, void *unused)
-{
-       struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
-       struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev,
-                                                           TTM_PL_VRAM);
-       struct drm_printer p = drm_seq_file_printer(m);
-
-       ttm_resource_manager_debug(man, &p);
-       return 0;
-}
-
 static int amdgpu_ttm_page_pool_show(struct seq_file *m, void *unused)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
@@ -2097,55 +2086,6 @@ static int amdgpu_ttm_page_pool_show(struct seq_file *m, 
void *unused)
        return ttm_pool_debugfs(&adev->mman.bdev.pool, m);
 }
 
-static int amdgpu_mm_tt_table_show(struct seq_file *m, void *unused)
-{
-       struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
-       struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev,
-                                                           TTM_PL_TT);
-       struct drm_printer p = drm_seq_file_printer(m);
-
-       ttm_resource_manager_debug(man, &p);
-       return 0;
-}
-
-static int amdgpu_mm_gds_table_show(struct seq_file *m, void *unused)
-{
-       struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
-       struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev,
-                                                           AMDGPU_PL_GDS);
-       struct drm_printer p = drm_seq_file_printer(m);
-
-       ttm_resource_manager_debug(man, &p);
-       return 0;
-}
-
-static int amdgpu_mm_gws_table_show(struct seq_file *m, void *unused)
-{
-       struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
-       struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev,
-                                                           AMDGPU_PL_GWS);
-       struct drm_printer p = drm_seq_file_printer(m);
-
-       ttm_resource_manager_debug(man, &p);
-       return 0;
-}
-
-static int amdgpu_mm_oa_table_show(struct seq_file *m, void *unused)
-{
-       struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
-       struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev,
-                                                           AMDGPU_PL_OA);
-       struct drm_printer p = drm_seq_file_printer(m);
-
-       ttm_resource_manager_debug(man, &p);
-       return 0;
-}
-
-DEFINE_SHOW_ATTRIBUTE(amdgpu_mm_vram_table);
-DEFINE_SHOW_ATTRIBUTE(amdgpu_mm_tt_table);
-DEFINE_SHOW_ATTRIBUTE(amdgpu_mm_gds_table);
-DEFINE_SHOW_ATTRIBUTE(amdgpu_mm_gws_table);
-DEFINE_SHOW_ATTRIBUTE(amdgpu_mm_oa_table);
 DEFINE_SHOW_ATTRIBUTE(amdgpu_ttm_page_pool);
 
 /*
@@ -2350,22 +2290,23 @@ void amdgpu_ttm_debugfs_init(struct amdgpu_device *adev)
 #if defined(CONFIG_DEBUG_FS)
        struct drm_minor *minor = adev_to_drm(adev)->primary;
        struct dentry *root = minor->debugfs_root;
+       const char * const ttm_placement_names[] = {
+               [TTM_PL_SYSTEM] = "system_ttm",
+               [TTM_PL_VRAM] = "amdgpu_vram_mm",
+               [TTM_PL_TT] = "amdgpu_gtt_mm",
+               [AMDGPU_PL_GDS] = "amdgpu_gds_mm",
+               [AMDGPU_PL_GWS] = "amdgpu_gws_mm",
+               [AMDGPU_PL_OA] = "amdgpu_oa_mm"
+       };
 
        debugfs_create_file_size("amdgpu_vram", 0444, root, adev,
                                 &amdgpu_ttm_vram_fops, adev->gmc.mc_vram_size);
        debugfs_create_file("amdgpu_iomem", 0444, root, adev,
                            &amdgpu_ttm_iomem_fops);
-       debugfs_create_file("amdgpu_vram_mm", 0444, root, adev,
-                           &amdgpu_mm_vram_table_fops);
-       debugfs_create_file("amdgpu_gtt_mm", 0444, root, adev,
-                           &amdgpu_mm_tt_table_fops);
-       debugfs_create_file("amdgpu_gds_mm", 0444, root, adev,
-                           &amdgpu_mm_gds_table_fops);
-       debugfs_create_file("amdgpu_gws_mm", 0444, root, adev,
-                           &amdgpu_mm_gws_table_fops);
-       debugfs_create_file("amdgpu_oa_mm", 0444, root, adev,
-                           &amdgpu_mm_oa_table_fops);
        debugfs_create_file("ttm_page_pool", 0444, root, adev,
                            &amdgpu_ttm_page_pool_fops);
+       ttm_resource_manager_debugfs_init(&adev->mman.bdev,
+                                         ttm_placement_names,
+                                         ARRAY_SIZE(ttm_placement_names));
 #endif
 }
-- 
2.32.0

Reply via email to