Am Freitag, dem 11.03.2022 um 18:06 +0100 schrieb Marek Vasut: > Reorder mxsfb_crtc_mode_set_nofb() such that all functions which perform > register IO are called from one single location in this function. This is > a clean up. No functional change. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: Alexander Stein <alexander.st...@ew.tq-group.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Lucas Stach <l.st...@pengutronix.de> > Cc: Peng Fan <peng....@nxp.com> > Cc: Robby Cai <robby....@nxp.com> > Cc: Sam Ravnborg <s...@ravnborg.org> > Cc: Stefan Agner <ste...@agner.ch>
Reviewed-by: Lucas Stach <l.st...@pengutronix.de> > --- > V2: No change > --- > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 14f5cc590a51b..497603964add8 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -289,13 +289,6 @@ static void mxsfb_crtc_mode_set_nofb(struct > mxsfb_drm_private *mxsfb, > u32 bus_flags = mxsfb->connector->display_info.bus_flags; > int err; > > - /* Mandatory eLCDIF reset as per the Reference Manual */ > - err = mxsfb_reset_block(mxsfb); > - if (err) > - return; > - > - mxsfb_set_formats(mxsfb, bus_format); > - > if (mxsfb->bridge && mxsfb->bridge->timings) > bus_flags = mxsfb->bridge->timings->input_bus_flags; > > @@ -306,6 +299,13 @@ static void mxsfb_crtc_mode_set_nofb(struct > mxsfb_drm_private *mxsfb, > bus_flags); > DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags); > > + /* Mandatory eLCDIF reset as per the Reference Manual */ > + err = mxsfb_reset_block(mxsfb); > + if (err) > + return; > + > + mxsfb_set_formats(mxsfb, bus_format); > + > mxsfb_set_mode(mxsfb, bus_flags); > } >
