Re: [PATCH] media: mediatek: vcodec: fix v4l2 compliance decoder cmd test fail

[AngeloGioacchino Del Regno]

Il 01/04/22 05:04, Yunfei Dong ha scritto:

Will return -EINVAL using standard framework api when test stateless
decoder with cmd VIDIOC_(TRY)DECODER_CMD.

Using another return value to adjust v4l2 compliance test for user
driver(GStreamer/Chrome) won't use decode cmd.

Signed-off-by: Yunfei Dong <yunfei.d...@mediatek.com>

Hello Yunfei,

this patch is a fix.. hence, this needs an appropriate Fixes: tag.
Please add one.

Thanks,
Angelo

---
  drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c 
b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
index 3859e4c651c6..69b0e797d342 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
@@ -51,8 +51,7 @@ static int vidioc_try_decoder_cmd(struct file *file, void 
*priv,

/* Use M2M stateless helper if relevant */

        if (ctx->dev->vdec_pdata->uses_stateless_api)
-               return v4l2_m2m_ioctl_stateless_try_decoder_cmd(file, priv,
-                                                               cmd);
+               return -ENOTTY;
        else
                return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd);
  }