We use the channel from our vc4_crtc_state structure in multiple places,
let's store it in a local variable to make it cleaner.

Signed-off-by: Maxime Ripard <max...@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_kms.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
index 24de29bc1cda..94c58ec37a27 100644
--- a/drivers/gpu/drm/vc4/vc4_kms.c
+++ b/drivers/gpu/drm/vc4/vc4_kms.c
@@ -279,13 +279,14 @@ static void vc5_hvs_pv_muxing_commit(struct vc4_dev *vc4,
        for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
                struct vc4_crtc_state *vc4_state = 
to_vc4_crtc_state(crtc_state);
                struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
+               unsigned int channel = vc4_state->assigned_channel;
 
                if (!vc4_state->update_muxing)
                        continue;
 
                switch (vc4_crtc->data->hvs_output) {
                case 2:
-                       mux = (vc4_state->assigned_channel == 2) ? 0 : 1;
+                       mux = (channel == 2) ? 0 : 1;
                        reg = HVS_READ(SCALER_DISPECTRL);
                        HVS_WRITE(SCALER_DISPECTRL,
                                  (reg & ~SCALER_DISPECTRL_DSP2_MUX_MASK) |
@@ -293,10 +294,10 @@ static void vc5_hvs_pv_muxing_commit(struct vc4_dev *vc4,
                        break;
 
                case 3:
-                       if (vc4_state->assigned_channel == 
VC4_HVS_CHANNEL_DISABLED)
+                       if (channel == VC4_HVS_CHANNEL_DISABLED)
                                mux = 3;
                        else
-                               mux = vc4_state->assigned_channel;
+                               mux = channel;
 
                        reg = HVS_READ(SCALER_DISPCTRL);
                        HVS_WRITE(SCALER_DISPCTRL,
@@ -305,10 +306,10 @@ static void vc5_hvs_pv_muxing_commit(struct vc4_dev *vc4,
                        break;
 
                case 4:
-                       if (vc4_state->assigned_channel == 
VC4_HVS_CHANNEL_DISABLED)
+                       if (channel == VC4_HVS_CHANNEL_DISABLED)
                                mux = 3;
                        else
-                               mux = vc4_state->assigned_channel;
+                               mux = channel;
 
                        reg = HVS_READ(SCALER_DISPEOLN);
                        HVS_WRITE(SCALER_DISPEOLN,
@@ -318,10 +319,10 @@ static void vc5_hvs_pv_muxing_commit(struct vc4_dev *vc4,
                        break;
 
                case 5:
-                       if (vc4_state->assigned_channel == 
VC4_HVS_CHANNEL_DISABLED)
+                       if (channel == VC4_HVS_CHANNEL_DISABLED)
                                mux = 3;
                        else
-                               mux = vc4_state->assigned_channel;
+                               mux = channel;
 
                        reg = HVS_READ(SCALER_DISPDITHER);
                        HVS_WRITE(SCALER_DISPDITHER,
-- 
2.35.1

Reply via email to