Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

[Kuogee Hsieh]

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote:

Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in
case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill)
the dp_mode argument. Drop it completely.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
Reviewed-by: Kuogee Hsieh <quic_khs...@quicinc.com>

---
  drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
  drivers/gpu/drm/msm/dp/dp_panel.c   | 2 +-
  drivers/gpu/drm/msm/dp/dp_panel.h   | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c 
b/drivers/gpu/drm/msm/dp/dp_display.c
index 178b774a5fbd..3dd790083cf7 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1013,7 +1013,7 @@ int dp_display_get_modes(struct msm_dp *dp,
        dp_display = container_of(dp, struct dp_display_private, dp_display);

ret = dp_panel_get_modes(dp_display->panel,

-               dp->connector, dp_mode);
+               dp->connector);
        if (dp_mode->drm_mode.clock)
                dp->max_pclk_khz = dp_mode->drm_mode.clock;
        return ret;
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c 
b/drivers/gpu/drm/msm/dp/dp_panel.c
index f1418722c549..8d7662028f30 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -259,7 +259,7 @@ u32 dp_panel_get_mode_bpp(struct dp_panel *dp_panel,
  }

int dp_panel_get_modes(struct dp_panel *dp_panel,

-       struct drm_connector *connector, struct dp_display_mode *mode)
+       struct drm_connector *connector)
  {
        if (!dp_panel) {
                DRM_ERROR("invalid input\n");
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h 
b/drivers/gpu/drm/msm/dp/dp_panel.h
index 9023e5bb4b8b..9fa6e524832c 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.h
+++ b/drivers/gpu/drm/msm/dp/dp_panel.h
@@ -64,7 +64,7 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
  u32 dp_panel_get_mode_bpp(struct dp_panel *dp_panel, u32 mode_max_bpp,
                        u32 mode_pclk_khz);
  int dp_panel_get_modes(struct dp_panel *dp_panel,
-               struct drm_connector *connector, struct dp_display_mode *mode);
+               struct drm_connector *connector);
  void dp_panel_handle_sink_request(struct dp_panel *dp_panel);
  void dp_panel_tpg_config(struct dp_panel *dp_panel, bool enable);