On 28.02.2022 21:02, Michal Wajdeczko wrote:
On 17.02.2022 15:41, Andi Shyti wrote:The "gt_is_root(struct intel_gt *gt)" helper return true if the gt is the root gt, which means that its id is 0. Return false otherwise. Suggested-by: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Andi Shyti <andi.sh...@linux.intel.com> --- drivers/gpu/drm/i915/gt/intel_gt.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index 915d6192079b..f17f51e2d394 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -19,6 +19,11 @@ struct drm_printer; ##__VA_ARGS__); \ } while (0)+static inline bool gt_is_root(struct intel_gt *gt)+{ + return !gt->info.id; +} +we could squash this patch with prev one, where it can be used in: intel_gt_tile_cleanup(struct intel_gt *gt) { intel_uncore_cleanup_mmio(gt->uncore); - if (gt->info.id) { + if (!gt_is_root(gt)) { kfree(gt->uncore); kfree(gt); } }
It can be used in intel_gt_tile_setup as well, and then you can remove id var.
or just use it this way in this patch, with that: Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com>
Accordingly: Reviewed-by: Andrzej Hajda <andrzej.ha...@intel.com> Regards Andrzej
static inline struct intel_gt *uc_to_gt(struct intel_uc *uc) { return container_of(uc, struct intel_gt, uc);
