The copy_to/from_user() functions return the number of bytes remaining
to be copied.  This function needs to return negative error codes
because snd_soc_pcm_component_copy_user() treats positive returns as
success in soc_component_ret().

Fixes: 7d7209557b67 ("ASoC: qcom: Add support for codec dma driver")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
 sound/soc/qcom/lpass-platform.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
index bf180a594c19..620312529c2f 100644
--- a/sound/soc/qcom/lpass-platform.c
+++ b/sound/soc/qcom/lpass-platform.c
@@ -1228,15 +1228,19 @@ static int lpass_platform_copy(struct snd_soc_component 
*component,
                                channel * (rt->dma_bytes / rt->channels));
 
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-               if (is_cdc_dma_port(dai_id))
+               if (is_cdc_dma_port(dai_id)) {
                        ret = copy_from_user_toio(dma_buf, buf, bytes);
-               else
-                       ret = copy_from_user((void __force *)dma_buf, buf, 
bytes);
+               } else {
+                       if (copy_from_user((void __force *)dma_buf, buf, bytes))
+                               ret = -EFAULT;
+               }
        } else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
-               if (is_cdc_dma_port(dai_id))
+               if (is_cdc_dma_port(dai_id)) {
                        ret = copy_to_user_fromio(buf, dma_buf, bytes);
-               else
-                       ret = copy_to_user(buf, (void __force *)dma_buf, bytes);
+               } else {
+                       if (copy_to_user(buf, (void __force *)dma_buf, bytes))
+                               ret = -EFAULT;
+               }
        }
 
        return ret;
-- 
2.20.1

Reply via email to