On 21/02/2022 10:19, Sergei Shtylyov wrote:
> On 2/20/22 5:55 PM, Sui Jingfeng wrote:
>
>> From: suijingfeng <suijingf...@loongson.cn>
>>
>> The display controller is a pci device, its PCI vendor id is 0x0014
>> its PCI device id is 0x7a06.
>>
>> 1) In order to let the driver to know which chip the DC is contained
>> in, the compatible string of the display controller is updated
>> according to the chip's name.
>>
>> 2) Add display controller device node for ls2k1000 SoC
>>
>> Reported-by: Krzysztof Kozlowski <k...@kernel.org>
>> Signed-off-by: suijingfeng <suijingf...@loongson.cn>
>> Signed-off-by: Sui Jingfeng <15330273...@189.cn>
>> ---
>> arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 8 ++++++++
>> arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 ++-----
>> 2 files changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> index 768cf2abcea3..af9cda540f9e 100644
>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> @@ -209,6 +209,14 @@ gpu@5,0 {
>> interrupt-parent = <&liointc0>;
>> };
>>
>> + lsdc: display-controller@6,0 {
>
> Shouldn't the node name just be "display", according to the section 2.2.2
> of the DT spec?
lcd-controller, led-controller. As I understood from the bindings, this
is not physical device displaying something (like a panel) but rather a
device controlling such panel. Therefore display-controller feels
appropriate.
Best regards,
Krzysztof
