Re: [Nouveau] Regression in 5.15 in nouveau

[Stefan Fritsch]

On 07.12.21 21:45, Dan Moulding wrote:
There is a pretty obvious typo in there:
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct
nouveau_channel *chan, bool e
                  fobj = dma_resv_shared_list(resv);
          }

-       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
+       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
                  struct nouveau_channel *prev = NULL;
                  bool must_wait = true;


With that it works and I don't see the flickering in a short test. I
will do more testing, but maybe Dan can test, too.

Cheers,
Stefan

After fixing the typo the patch is working for me, also. dmesg is also
clean. I will continue running the patched kernel. If I see any
issues, I will report back here.

OK, looks good: I have tested it on top of v5.15.5 for a day and no 
black flickering and no other problems. I am not qualified to review the 
patch, though.

Thanks for the quick responses to everyone.

Cheers,
Stefan