Re: [PATCH 10/12] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

[Michael Riesch]

Hi Sascha,

On 11/17/21 3:33 PM, Sascha Hauer wrote:

This enabled the VOP2 display controller along with hdmi and the
required port routes which is enough to get a picture out of the
hdmi port of the board.

Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de>
---
  .../boot/dts/rockchip/rk3568-evb1-v10.dts     | 24 +++++++++++++++++++
  1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts 
b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
index 184e2aa2416af..156e001492173 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
@@ -106,6 +106,12 @@ &gmac1m1_rgmii_clk
        status = "okay";
  };

+&hdmi {

+       status = "okay";
+       avdd-0v9-supply = <&vdda0v9_image>;
+       avdd-1v8-supply = <&vcca1v8_image>;
+};
+
  &i2c0 {
        status = "okay";

@@ -390,3 +396,21 @@ &sdmmc0 {

  &uart2 {
        status = "okay";
  };
+
+&vop {
+       status = "okay";
+       assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+       assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+};
+
+&vop_mmu {
+       status = "okay";
+};
+
+&hdmi_in_vp0 {
+       status = "okay";
+};

Minor nitpick: This should probably be sorted alphabetically.

Best regards,
Michael

+
+&vp0_out_hdmi {
+       status = "okay";
+};