When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoq...@baidu.com>
---
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c 
b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 4f5efcace68e..be60b16bcea9 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -1128,10 +1128,9 @@ static int sun6i_dsi_probe(struct platform_device *pdev)
        }
 
        dsi->regulator = devm_regulator_get(dev, "vcc-dsi");
-       if (IS_ERR(dsi->regulator)) {
-               dev_err(dev, "Couldn't get VCC-DSI supply\n");
-               return PTR_ERR(dsi->regulator);
-       }
+       if (IS_ERR(dsi->regulator))
+               return dev_err_probe(dev, PTR_ERR(dsi->regulator),
+                                    "Couldn't get VCC-DSI supply\n");
 
        dsi->reset = devm_reset_control_get_shared(dev, NULL);
        if (IS_ERR(dsi->reset)) {
@@ -1146,10 +1145,9 @@ static int sun6i_dsi_probe(struct platform_device *pdev)
        }
 
        dsi->bus_clk = devm_clk_get(dev, bus_clk_name);
-       if (IS_ERR(dsi->bus_clk)) {
-               dev_err(dev, "Couldn't get the DSI bus clock\n");
-               return PTR_ERR(dsi->bus_clk);
-       }
+       if (IS_ERR(dsi->bus_clk))
+               return dev_err_probe(dev, PTR_ERR(dsi->bus_clk),
+                                    "Couldn't get the DSI bus clock\n");
 
        ret = regmap_mmio_attach_clk(dsi->regs, dsi->bus_clk);
        if (ret)
-- 
2.25.1

Reply via email to