Dear Philipp,
Thanks for the review.
On Mon, 2021-09-06 at 09:29 +0200, Philipp Zabel wrote:
> Hi Nancy,
>
> On Mon, 2021-09-06 at 15:15 +0800, Nancy.Lin wrote:
> > MT8195 vdosys1 has more than 32 reset bits and a different reset
> > base
> > than other chips. Modify mmsys for support 64 bit and different
> > reset
> > base.
> >
> > Signed-off-by: Nancy.Lin <nancy....@mediatek.com>
> > ---
> > drivers/soc/mediatek/mt8195-mmsys.h | 1 +
> > drivers/soc/mediatek/mtk-mmsys.c | 15 ++++++++++++---
> > drivers/soc/mediatek/mtk-mmsys.h | 1 +
> > 3 files changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mt8195-mmsys.h
> > b/drivers/soc/mediatek/mt8195-mmsys.h
> > index 648baaec112b..f67801c42fd9 100644
> > --- a/drivers/soc/mediatek/mt8195-mmsys.h
> > +++ b/drivers/soc/mediatek/mt8195-mmsys.h
> > @@ -123,6 +123,7 @@
> > #define MT8195_VDO1_MIXER_SOUT_SEL_IN
> > 0xf68
> > #define MT8195_MIXER_SOUT_SEL_IN_FROM_DISP_MIXER (0 <<
> > 0)
> >
> > +#define MT8195_VDO1_SW0_RST_B 0x1d0
> > #define MT8195_VDO1_MERGE0_ASYNC_CFG_WD 0xe30
> > #define MT8195_VDO1_MERGE1_ASYNC_CFG_WD 0xe40
> > #define MT8195_VDO1_MERGE2_ASYNC_CFG_WD 0xe50
> > diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> > b/drivers/soc/mediatek/mtk-mmsys.c
> > index 060065501b8a..97cb26339ef6 100644
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
> > @@ -18,6 +18,8 @@
> > #include "mt8365-mmsys.h"
> > #include "mt8195-mmsys.h"
> >
> > +#define MMSYS_SW_RESET_PER_REG 32
> > +
> > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data
> > = {
> > .clk_driver = "clk-mt2701-mm",
> > .routes = mmsys_default_routing_table,
> > @@ -48,12 +50,14 @@ static const struct mtk_mmsys_driver_data
> > mt8173_mmsys_driver_data = {
> > .clk_driver = "clk-mt8173-mm",
> > .routes = mmsys_default_routing_table,
> > .num_routes = ARRAY_SIZE(mmsys_default_routing_table),
> > + .sw_reset_start = MMSYS_SW0_RST_B,
> > };
> >
> > static const struct mtk_mmsys_driver_data mt8183_mmsys_driver_data
> > = {
> > .clk_driver = "clk-mt8183-mm",
> > .routes = mmsys_mt8183_routing_table,
> > .num_routes = ARRAY_SIZE(mmsys_mt8183_routing_table),
> > + .sw_reset_start = MMSYS_SW0_RST_B,
> > };
> >
> > static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data
> > = {
> > @@ -74,6 +78,7 @@ static const struct mtk_mmsys_driver_data
> > mt8195_vdosys1_driver_data = {
> > .num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table),
> > .config = mmsys_mt8195_config_table,
> > .num_configs = ARRAY_SIZE(mmsys_mt8195_config_table),
> > + .sw_reset_start = MT8195_VDO1_SW0_RST_B,
> > };
> >
> > struct mtk_mmsys {
> > @@ -126,19 +131,23 @@ static int mtk_mmsys_reset_update(struct
> > reset_controller_dev *rcdev, unsigned l
> > {
> > struct mtk_mmsys *mmsys = container_of(rcdev, struct mtk_mmsys,
> > rcdev);
> > unsigned long flags;
> > + u32 offset;
> > u32 reg;
> > int i;
> >
> > + offset = (id / MMSYS_SW_RESET_PER_REG) * sizeof(u32);
> > + id = id % MMSYS_SW_RESET_PER_REG;
> > +
> > spin_lock_irqsave(&mmsys->lock, flags);
> >
> > - reg = readl_relaxed(mmsys->regs + MMSYS_SW0_RST_B);
> > + reg = readl_relaxed(mmsys->regs + mmsys->data->sw_reset_start +
> > offset);
> >
> > if (assert)
> > reg &= ~BIT(id);
> > else
> > reg |= BIT(id);
> >
> > - writel_relaxed(reg, mmsys->regs + MMSYS_SW0_RST_B);
> > + writel_relaxed(reg, mmsys->regs + mmsys->data->sw_reset_start +
> > offset);
> >
> > spin_unlock_irqrestore(&mmsys->lock, flags);
> >
> > @@ -237,7 +246,7 @@ static int mtk_mmsys_probe(struct
> > platform_device *pdev)
> > spin_lock_init(&mmsys->lock);
> >
> > mmsys->rcdev.owner = THIS_MODULE;
> > - mmsys->rcdev.nr_resets = 32;
> > + mmsys->rcdev.nr_resets = 64;
>
> If only MT8195 vdosys1 has more than 32 reset bits, this should be
> kept
> at 32 for the others.
>
> regards
OK, I will modify it in the next revision.
> Philipp
