Hi Vinod,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.13]
[cannot apply to linus/master v5.14-rc1 next-20210716]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
base:    62fb9874f5da54fdb243003b386128037319b219
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/e61efb569c28d8036eb18f53763c195c16d8a396
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
        git checkout e61efb569c28d8036eb18f53763c195c16d8a396
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross 
ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function 
'dpu_encoder_prep_dsc':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1911:17: warning: variable 
>> 'pic_height' set but not used [-Wunused-but-set-variable]
    1911 |  int pic_width, pic_height;
         |                 ^~~~~~~~~~


vim +/pic_height +1911 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

  1900  
  1901  static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc,
  1902                                   struct msm_display_dsc_config *dsc)
  1903  {
  1904          /* coding only for 2LM, 2enc, 1 dsc config */
  1905          struct dpu_encoder_phys *enc_master = dpu_enc->cur_master;
  1906          struct dpu_hw_dsc *hw_dsc[MAX_CHANNELS_PER_ENC];
  1907          struct dpu_hw_pingpong *hw_pp[MAX_CHANNELS_PER_ENC];
  1908          int this_frame_slices;
  1909          int intf_ip_w, enc_ip_w;
  1910          int dsc_common_mode;
> 1911          int pic_width, pic_height;
  1912          int i;
  1913  
  1914          for (i = 0; i < MAX_CHANNELS_PER_ENC; i++) {
  1915                  hw_pp[i] = dpu_enc->hw_pp[i];
  1916                  hw_dsc[i] = dpu_enc->hw_dsc[i];
  1917  
  1918                  if (!hw_pp[i] || !hw_dsc[i]) {
  1919                          DPU_ERROR_ENC(dpu_enc, "invalid params for 
DSC\n");
  1920                          return;
  1921                  }
  1922          }
  1923  
  1924          dsc_common_mode = 0;
  1925          pic_width = dsc->drm->pic_width;
  1926          pic_height = dsc->drm->pic_height;
  1927  
  1928          dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
  1929          if (enc_master->intf_mode == INTF_MODE_VIDEO)
  1930                  dsc_common_mode |= DSC_MODE_VIDEO;
  1931  
  1932          this_frame_slices = pic_width / dsc->drm->slice_width;
  1933          intf_ip_w = this_frame_slices * dsc->drm->slice_width;
  1934  
  1935          dpu_encoder_dsc_pclk_param_calc(dsc, intf_ip_w);
  1936  
  1937          /*
  1938           * dsc merge case: when using 2 encoders for the same stream,
  1939           * no. of slices need to be same on both the encoders.
  1940           */
  1941          enc_ip_w = intf_ip_w / 2;
  1942          dpu_encoder_dsc_initial_line_calc(dsc, enc_ip_w);
  1943  
  1944          for (i = 0; i < MAX_CHANNELS_PER_ENC; i++)
  1945                  dpu_encoder_dsc_pipe_cfg(hw_dsc[i], hw_pp[i], dsc, 
dsc_common_mode);
  1946  }
  1947  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to