Re: [PATCH -next] drm/nouveau: Remove set but not used variable 'width'

[libaokun (A)]

ping

在 2021/5/25 16:17, Baokun Li 写道:

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/nouveau/nouveau_display.c: In function 
'nouveau_framebuffer_new':
drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
  variable ‘width’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <libaok...@huawei.com>
---
  drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c 
b/drivers/gpu/drm/nouveau/nouveau_display.c
index 929de41c281f..2b460835a438 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
        struct nouveau_bo *nvbo = nouveau_gem_object(gem);
        struct drm_framebuffer *fb;
        const struct drm_format_info *info;
-       unsigned int width, height, i;
+       unsigned int height, i;
        uint32_t tile_mode;
        uint8_t kind;
        int ret;
@@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
        info = drm_get_format_info(dev, mode_cmd);

for (i = 0; i < info->num_planes; i++) {

-               width = drm_format_info_plane_width(info,
-                                                   mode_cmd->width,
-                                                   i);
                height = drm_format_info_plane_height(info,
                                                      mode_cmd->height,
                                                      i);