On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote: > Even when all we support is linear, make that explicit. Otherwise the > uapi is rather confusing.
:) > > Cc: sta...@vger.kernel.org > Cc: Pekka Paalanen <pekka.paala...@collabora.com> > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Acked-by: Liviu Dudau <liviu.du...@arm.com> Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_planes.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c > b/drivers/gpu/drm/arm/malidp_planes.c > index ddbba67f0283..8c2ab3d653b7 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -927,6 +927,11 @@ static const struct drm_plane_helper_funcs > malidp_de_plane_helper_funcs = { > .atomic_disable = malidp_de_plane_disable, > }; > > +static const uint64_t linear_only_modifiers[] = { > + DRM_FORMAT_MOD_LINEAR, > + DRM_FORMAT_MOD_INVALID > +}; > + > int malidp_de_planes_init(struct drm_device *drm) > { > struct malidp_drm *malidp = drm->dev_private; > @@ -990,8 +995,8 @@ int malidp_de_planes_init(struct drm_device *drm) > */ > ret = drm_universal_plane_init(drm, &plane->base, crtcs, > &malidp_de_plane_funcs, formats, n, > - (id == DE_SMART) ? NULL : modifiers, plane_type, > - NULL); > + (id == DE_SMART) ? linear_only_modifiers : > modifiers, > + plane_type, NULL); > > if (ret < 0) > goto cleanup; > -- > 2.31.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel