Hi Jagan,

On 2021-02-14 18:44, Jagan Teki wrote:
[...]
+static void sn65dsi_enable(struct drm_bridge *bridge)
+{
+       struct sn65dsi *sn = bridge_to_sn65dsi(bridge);
+       struct drm_display_mode *mode = bridge_to_mode(bridge);
+       int bpp = mipi_dsi_pixel_format_to_bpp(sn->dsi->format);
+       unsigned int lanes = sn->dsi->lanes;
+       unsigned int pixel_clk = mode->clock * 1000;
+       unsigned int dsi_clk = pixel_clk * bpp / (lanes * 2);
+       unsigned int val;
+
+       /* reset SOFT_RESET bit */
+       regmap_write(sn->regmap, SN65DSI_SOFT_RESET, 0x0);
+
+       msleep(10);
+
+       /* reset PLL_EN bit */
+       regmap_write(sn->regmap, SN65DSI_CLK_PLL, 0x0);
+
+       msleep(10);
+
+       /* setup lvds clock */
+       val = sn65dsi_get_clk_range(0, 5, pixel_clk, 25000000, 25000000);
+       if (val < 0) {

val is unsigned int, so it can never be negative so this condition is always false. Same error further down in that function as well.

regards,
Claudius
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to