Hi Liu, Thank you for the patch! Yet something to improve:
[auto build test ERROR on shawnguo/for-next] [also build test ERROR on robh/for-next drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc3 next-20210319] [cannot apply to drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Liu-Ying/Add-some-DRM-bridge-drivers-support-for-i-MX8qm-qxp-SoCs/20210317-115847 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2a10a7804cc3ac91a22aca483e688326082219fa git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Liu-Ying/Add-some-DRM-bridge-drivers-support-for-i-MX8qm-qxp-SoCs/20210317-115847 git checkout 2a10a7804cc3ac91a22aca483e688326082219fa # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:69:15: warning: 'struct phy_configure_opts_lvds' declared inside parameter list will not be visible outside of this definition or declaration 69 | struct phy_configure_opts_lvds *phy_cfg) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c: In function 'imx8qm_ldb_set_phy_cfg': >> drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:71:9: error: dereferencing >> pointer to incomplete type 'struct phy_configure_opts_lvds' 71 | phy_cfg->bits_per_lane_and_dclk_cycle = 7; | ^~ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c: In function 'imx8qm_ldb_bridge_atomic_check': >> drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:91:49: error: 'union >> phy_configure_opts' has no member named 'lvds' 91 | struct phy_configure_opts_lvds *phy_cfg = &opts.lvds; | ^ >> drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:99:62: error: passing argument 5 >> of 'imx8qm_ldb_set_phy_cfg' from incompatible pointer type >> [-Werror=incompatible-pointer-types] 99 | imx8qm_ldb_set_phy_cfg(imx8qm_ldb, di_clk, is_split, false, phy_cfg); | ^~~~~~~ | | | struct phy_configure_opts_lvds * drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:69:40: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *' 69 | struct phy_configure_opts_lvds *phy_cfg) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:111:10: error: passing argument 5 of 'imx8qm_ldb_set_phy_cfg' from incompatible pointer type [-Werror=incompatible-pointer-types] 111 | phy_cfg); | ^~~~~~~ | | | struct phy_configure_opts_lvds * drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:69:40: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *' 69 | struct phy_configure_opts_lvds *phy_cfg) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c: In function 'imx8qm_ldb_bridge_mode_set': drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:137:49: error: 'union phy_configure_opts' has no member named 'lvds' 137 | struct phy_configure_opts_lvds *phy_cfg = &opts.lvds; | ^ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:152:62: error: passing argument 5 of 'imx8qm_ldb_set_phy_cfg' from incompatible pointer type [-Werror=incompatible-pointer-types] 152 | imx8qm_ldb_set_phy_cfg(imx8qm_ldb, di_clk, is_split, false, phy_cfg); | ^~~~~~~ | | | struct phy_configure_opts_lvds * drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:69:40: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *' 69 | struct phy_configure_opts_lvds *phy_cfg) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:161:10: error: passing argument 5 of 'imx8qm_ldb_set_phy_cfg' from incompatible pointer type [-Werror=incompatible-pointer-types] 161 | phy_cfg); | ^~~~~~~ | | | struct phy_configure_opts_lvds * drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c:69:40: note: expected 'struct phy_configure_opts_lvds *' but argument is of type 'struct phy_configure_opts_lvds *' 69 | struct phy_configure_opts_lvds *phy_cfg) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ cc1: some warnings being treated as errors vim +71 drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c 65 66 static void imx8qm_ldb_set_phy_cfg(struct imx8qm_ldb *imx8qm_ldb, 67 unsigned long di_clk, 68 bool is_split, bool is_slave, > 69 struct phy_configure_opts_lvds *phy_cfg) 70 { > 71 phy_cfg->bits_per_lane_and_dclk_cycle = 7; 72 phy_cfg->lanes = 4; 73 phy_cfg->differential_clk_rate = is_split ? di_clk / 2 : di_clk; 74 phy_cfg->is_slave = is_slave; 75 } 76 77 static int imx8qm_ldb_bridge_atomic_check(struct drm_bridge *bridge, 78 struct drm_bridge_state *bridge_state, 79 struct drm_crtc_state *crtc_state, 80 struct drm_connector_state *conn_state) 81 { 82 struct ldb_channel *ldb_ch = bridge->driver_private; 83 struct ldb *ldb = ldb_ch->ldb; 84 struct imx8qm_ldb_channel *imx8qm_ldb_ch = 85 base_to_imx8qm_ldb_channel(ldb_ch); 86 struct imx8qm_ldb *imx8qm_ldb = base_to_imx8qm_ldb(ldb); 87 struct drm_display_mode *adj = &crtc_state->adjusted_mode; 88 unsigned long di_clk = adj->clock * 1000; 89 bool is_split = ldb_channel_is_split_link(ldb_ch); 90 union phy_configure_opts opts = { }; > 91 struct phy_configure_opts_lvds *phy_cfg = &opts.lvds; 92 int ret; 93 94 ret = ldb_bridge_atomic_check_helper(bridge, bridge_state, 95 crtc_state, conn_state); 96 if (ret) 97 return ret; 98 > 99 imx8qm_ldb_set_phy_cfg(imx8qm_ldb, di_clk, is_split, false, phy_cfg); 100 ret = phy_validate(imx8qm_ldb_ch->phy, PHY_MODE_LVDS, 0, &opts); 101 if (ret < 0) { 102 DRM_DEV_DEBUG_DRIVER(imx8qm_ldb->dev, 103 "failed to validate PHY: %d\n", ret); 104 return ret; 105 } 106 107 if (is_split) { 108 imx8qm_ldb_ch = 109 &imx8qm_ldb->channel[imx8qm_ldb->active_chno ^ 1]; 110 imx8qm_ldb_set_phy_cfg(imx8qm_ldb, di_clk, is_split, true, 111 phy_cfg); 112 ret = phy_validate(imx8qm_ldb_ch->phy, PHY_MODE_LVDS, 0, &opts); 113 if (ret < 0) { 114 DRM_DEV_DEBUG_DRIVER(imx8qm_ldb->dev, 115 "failed to validate slave PHY: %d\n", ret); 116 return ret; 117 } 118 } 119 120 return ret; 121 } 122 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
