> -----Original Message----- > From: Jason Gunthorpe <[email protected]> > Sent: Tuesday, December 08, 2020 10:59 AM > To: Xiong, Jianxin <[email protected]> > Cc: Leon Romanovsky <[email protected]>; [email protected]; > [email protected]; Doug Ledford > <[email protected]>; Sumit Semwal <[email protected]>; Christian > Koenig <[email protected]>; Vetter, Daniel > <[email protected]> > Subject: Re: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user > memory region > > On Tue, Dec 08, 2020 at 06:13:20PM +0000, Xiong, Jianxin wrote: > > > > > +static inline struct ib_umem *ib_umem_dmabuf_get(struct ib_device > > > > *device, > > > > + unsigned long offset, > > > > + size_t size, int fd, > > > > + int access, > > > > + struct > > > > dma_buf_attach_ops *ops) { > > > > + return ERR_PTR(-EINVAL); > > > > > > Probably, It should be EOPNOTSUPP and not EINVAL. > > > > EINVAL is used here to be consistent with existing definitions in the same > > file. > > They may be wrong, EOPNOTSUPP is right for this situation
Ok, let me change all of them to EOPNOTSUPP. _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
