On Thu, 3 Dec 2020 21:45:14 +0100 Daniel Vetter <dan...@ffwll.ch> wrote:
> On Thu, Dec 3, 2020 at 7:55 PM James Park <james.p...@lagfreegames.com> wrote: > > > > The trailing underscore for DRM_FOURCC_STANDALONE_ isn't > > intentional, right? Should I put all the integer types, or just the > > ones that are used in that file? > > Yeah that trailing _ just slipped in. And I'd just do the types > already used. I don't think anything else than __u32 (for drm fourcc) > and __u64 (for drm modifier) is needed. Hi, can that create conflicts if userspace first includes drm_fourcc.h and then drm.h? I would find it natural to userspace have generic headers including drm_fourcc.h and then DRM-specific C-files including drm.h as well (through libdrm headers). I think Weston might already do this. The generic userspace (weston) header would obviously #define DRM_FOURCC_STANDALONE, because it is used by non-DRM C-files as well. Thanks, pq
pgpovByJzZkXi.pgp
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
