On Thu, Nov 26, 2020 at 8:44 AM Lee Jones <lee.jo...@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c: In > function ‘dm_dtn_log_append_v’: > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:345:2: > warning: function ‘dm_dtn_log_append_v’ might be a candidate for ‘gnu_printf’ > format attribute [-Wsuggest-attribute=format] > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:375:3: > warning: function ‘dm_dtn_log_append_v’ might be a candidate for ‘gnu_printf’ > format attribute [-Wsuggest-attribute=format] > > Cc: Harry Wentland <harry.wentl...@amd.com> > Cc: Leo Li <sunpeng...@amd.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: "Christian König" <christian.koe...@amd.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > index b7d7ec3ba00d7..24a81642baa26 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > @@ -318,6 +318,7 @@ void dm_dtn_log_begin(struct dc_context *ctx, > dm_dtn_log_append_v(ctx, log_ctx, "%s", msg); > } > > +__printf(3, 4)
Can you expand a bit on what this does? Alex > void dm_dtn_log_append_v(struct dc_context *ctx, > struct dc_log_buffer_ctx *log_ctx, > const char *msg, ...) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
