Hi Neil,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iommu/next]
[also build test WARNING on soc/for-next linus/master v5.9-rc4 next-20200908]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Neil-Armstrong/drm-panfrost-add-Amlogic-integration-quirks/20200908-232205
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm-randconfig-r014-20200908 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 
df63eedef64d715ce1f31843f7de9c11fe1e597f)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/panfrost/panfrost_gpu.c:82:6: warning: no previous prototype 
>> for function 'panfrost_gpu_amlogic_quirks' [-Wmissing-prototypes]
   void panfrost_gpu_amlogic_quirks(struct panfrost_device *pfdev)
        ^
   drivers/gpu/drm/panfrost/panfrost_gpu.c:82:1: note: declare 'static' if the 
function is not intended to be used outside of this translation unit
   void panfrost_gpu_amlogic_quirks(struct panfrost_device *pfdev)
   ^
   static 
   1 warning generated.

# 
https://github.com/0day-ci/linux/commit/10c9c1e2d5b129f4936ea0b84cb489da43364d8c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Neil-Armstrong/drm-panfrost-add-Amlogic-integration-quirks/20200908-232205
git checkout 10c9c1e2d5b129f4936ea0b84cb489da43364d8c
vim +/panfrost_gpu_amlogic_quirks +82 drivers/gpu/drm/panfrost/panfrost_gpu.c

    81  
  > 82  void panfrost_gpu_amlogic_quirks(struct panfrost_device *pfdev)
    83  {
    84          /*
    85           * The Amlogic integrated Mali-T820, Mali-G31 & Mali-G52 needs
    86           * these undocumented bits to be set in order to operate
    87           * correctly.
    88           * These GPU_PWR registers contains:
    89           * "device-specific power control value"
    90           */
    91          gpu_write(pfdev, GPU_PWR_KEY, 0x2968A819);
    92          gpu_write(pfdev, GPU_PWR_OVERRIDE1, 0xfff | (0x20 << 16));
    93  }
    94  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to