Hi Sam thanks for taken care of this issue. Alpha is a rare architecture these days. How do you build and test for it?
Am 07.08.20 um 20:05 schrieb Sam Ravnborg:
> When building imgag200 for the alpha architecture it fails like this:
> mgag200_drv.c:233:9: error: implicit declaration of function ‘vmalloc’
> 233 | bios = vmalloc(size);
> | ^~~~~~~
> | kmalloc
>
> When building for other architectures vmalloc.h is pulled in via some
> other header file - for example asm-generic/io.h.
> Use an explicit include of vmalloc.h to fix the build.
>
> Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Sorry for being (too) late, but still:
Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>
Best regards
Thomas
> Fixes: e20dfd27f7aa ("drm/mgag200: Add support for G200 desktop cards")
> Cc: Thomas Zimmermann <tzimmerm...@suse.de>
> Cc: Egbert Eich <e...@suse.com>
> Cc: Takashi Iwai <ti...@suse.de>
> Cc: Lyude Paul <ly...@redhat.com>
> ---
> I have lost track if the offending commit is on the way to upstream or
> it is just in drm-misc-next. But I think it is the latter so we can
> apply this to drm-misc-next.
>
> Sam
>
> drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c
> b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 09170d46aa53..b282b0e42c2d 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -9,6 +9,7 @@
> #include <linux/console.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/vmalloc.h>
>
> #include <drm/drm_drv.h>
> #include <drm/drm_file.h>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
