Hi Gwan-gyeong, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20200507] [cannot apply to tegra-drm/drm/tegra/for-next linus/master v5.7-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Gwan-gyeong-Mun/In-order-to-readout-DP-SDPs-refactors-the-handling-of-DP-SDPs/20200508-034404 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> New smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:727 intel_psr_compute_config() warn: inconsistent indenting Old smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:1564 intel_psr_short_pulse() error: uninitialized symbol 'error_status'. drivers/gpu/drm/i915/display/intel_psr.c:1569 intel_psr_short_pulse() error: uninitialized symbol 'error_status'. vim +727 drivers/gpu/drm/i915/display/intel_psr.c 711 712 void intel_psr_compute_config(struct intel_dp *intel_dp, 713 struct intel_crtc_state *crtc_state) 714 { 715 struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 716 struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 717 const struct drm_display_mode *adjusted_mode = 718 &crtc_state->hw.adjusted_mode; 719 int psr_setup_time; 720 721 if (!CAN_PSR(dev_priv)) 722 return; 723 724 if (intel_dp != dev_priv->psr.dp) 725 return; 726 > 727 if (!psr_global_enabled(dev_priv)) 728 return; 729 /* 730 * HSW spec explicitly says PSR is tied to port A. 731 * BDW+ platforms have a instance of PSR registers per transcoder but 732 * for now it only supports one instance of PSR, so lets keep it 733 * hardcoded to PORT_A 734 */ 735 if (dig_port->base.port != PORT_A) { 736 drm_dbg_kms(&dev_priv->drm, 737 "PSR condition failed: Port not supported\n"); 738 return; 739 } 740 741 if (dev_priv->psr.sink_not_reliable) { 742 drm_dbg_kms(&dev_priv->drm, 743 "PSR sink implementation is not reliable\n"); 744 return; 745 } 746 747 if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) { 748 drm_dbg_kms(&dev_priv->drm, 749 "PSR condition failed: Interlaced mode enabled\n"); 750 return; 751 } 752 753 psr_setup_time = drm_dp_psr_setup_time(intel_dp->psr_dpcd); 754 if (psr_setup_time < 0) { 755 drm_dbg_kms(&dev_priv->drm, 756 "PSR condition failed: Invalid PSR setup time (0x%02x)\n", 757 intel_dp->psr_dpcd[1]); 758 return; 759 } 760 761 if (intel_usecs_to_scanlines(adjusted_mode, psr_setup_time) > 762 adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vdisplay - 1) { 763 drm_dbg_kms(&dev_priv->drm, 764 "PSR condition failed: PSR setup time (%d us) too long\n", 765 psr_setup_time); 766 return; 767 } 768 769 crtc_state->has_psr = true; 770 crtc_state->has_psr2 = intel_psr2_config_valid(intel_dp, crtc_state); 771 crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_VSC); 772 } 773 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
