Hi Am 30.04.20 um 11:22 schrieb Sam Ravnborg: > Hi Thomas. > > On Thu, Apr 30, 2020 at 11:13:30AM +0200, Thomas Zimmermann wrote: >> Suspending failed because there's no mode if the CRTC is being >> disabled. Early-out in this case. This fixes runtime PM for ast. >> >> Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de> > > Don't you miss: > > Reported-by: > Tested-by:
Waiting for the reporter's ok. > Fixes: Indeed. :( Best regards Thomas > ??? > > Sam > >> --- >> drivers/gpu/drm/ast/ast_mode.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c >> index 7a9f20a2fd303..089b7d9a0cf3f 100644 >> --- a/drivers/gpu/drm/ast/ast_mode.c >> +++ b/drivers/gpu/drm/ast/ast_mode.c >> @@ -801,6 +801,9 @@ static int ast_crtc_helper_atomic_check(struct drm_crtc >> *crtc, >> return -EINVAL; >> } >> >> + if (!state->enable) >> + return 0; /* no checks required if CRTC is being disabled */ >> + >> ast_state = to_ast_crtc_state(state); >> >> format = ast_state->format; >> -- >> 2.26.0 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
