Hi Sam,

Thank you for the patch.

On Wed, Apr 08, 2020 at 08:29:26PM +0200, Sam Ravnborg wrote:
> Laurent Pinchart <laurent.pinch...@ideasonboard.com> and
> Jani Nikula <jani.nik...@intel.com> both
> suggested to make the pointer to struct ipu_di_signal_cfg const.
> 
> Fix this.
> 
> Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
> Fixes: 3f6c93ec9254 ("fbdev: mx3fb: avoid warning about psABI change")
> Cc: Jani Nikula <jani.nik...@intel.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Sam Ravnborg <s...@ravnborg.org>
> Cc: Enrico Weigelt <i...@metux.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
> Cc: linux-fb...@vger.kernel.org

Assuming this is compile-tested,

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> ---
> 
> Again, sorry. I should have waited a day before applying.
> 
>       Sam
> 
>  drivers/video/fbdev/mx3fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index e13fea3a292f..603731a5a72e 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -509,7 +509,7 @@ static int sdc_init_panel(struct mx3fb_data *mx3fb, enum 
> ipu_panel panel,
>                         uint16_t h_start_width, uint16_t h_sync_width,
>                         uint16_t h_end_width, uint16_t v_start_width,
>                         uint16_t v_sync_width, uint16_t v_end_width,
> -                       struct ipu_di_signal_cfg *sig)
> +                       const struct ipu_di_signal_cfg *sig)
>  {
>       unsigned long lock_flags;
>       uint32_t reg;

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to