Hi Angelo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.6 next-20200404]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Angelo-Ribeiro/drm-bridge-dw-mipi-dsi-c-Add-VPG-runtime-config-through-debugfs/20200405-032129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
83eb69f3b80f7cf2ca6357fb9c23adc48632a0e3
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c: In function 
'dw_mipi_dsi_video_mode_config':
>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:555:42: error: 
>> 'VID_MODE_VPG_MODE' undeclared (first use in this function); did you mean 
>> 'VID_MODE_VPG_ENABLE'?
     555 |   val |= dsi->vpg_defs.vpg_ber_pattern ? VID_MODE_VPG_MODE : 0;
         |                                          ^~~~~~~~~~~~~~~~~
         |                                          VID_MODE_VPG_ENABLE
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:555:42: note: each undeclared 
identifier is reported only once for each function it appears in
   In file included from drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:13:
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c: In function 'fops_x32_open':
>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:1024:36: error: passing 
>> argument 3 of 'simple_attr_open' from incompatible pointer type 
>> [-Werror=incompatible-pointer-types]
    1024 | DEFINE_DEBUGFS_ATTRIBUTE(fops_x32, dw_mipi_dsi_debugfs_show,
         |                                    ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                    |
         |                                    ssize_t (*)(void *, u64 *) {aka 
long int (*)(void *, long long unsigned int *)}
   include/linux/debugfs.h:47:39: note: in definition of macro 
'DEFINE_DEBUGFS_ATTRIBUTE'
      47 |  return simple_attr_open(inode, file, __get, __set, __fmt); \
         |                                       ^~~~~
   In file included from include/linux/debugfs.h:15,
                    from drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:13:
   include/linux/fs.h:3529:14: note: expected 'int (*)(void *, u64 *)' {aka 
'int (*)(void *, long long unsigned int *)'} but argument is of type 'ssize_t 
(*)(void *, u64 *)' {aka 'long int (*)(void *, long long unsigned int *)'}
    3529 |        int (*get)(void *, u64 *), int (*set)(void *, u64),
         |        ~~~~~~^~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:13:
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:1025:5: error: passing 
argument 4 of 'simple_attr_open' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
    1025 |     dw_mipi_dsi_debugfs_write, "%llu\n");
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
         |     |
         |     ssize_t (*)(void *, u64) {aka long int (*)(void *, long long 
unsigned int)}
   include/linux/debugfs.h:47:46: note: in definition of macro 
'DEFINE_DEBUGFS_ATTRIBUTE'
      47 |  return simple_attr_open(inode, file, __get, __set, __fmt); \
         |                                              ^~~~~
   In file included from include/linux/debugfs.h:15,
                    from drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:13:
   include/linux/fs.h:3529:41: note: expected 'int (*)(void *, u64)' {aka 'int 
(*)(void *, long long unsigned int)'} but argument is of type 'ssize_t (*)(void 
*, u64)' {aka 'long int (*)(void *, long long unsigned int)'}
    3529 |        int (*get)(void *, u64 *), int (*set)(void *, u64),
         |                                   ~~~~~~^~~~~~~~~~~~~~~~~
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c: In function 
'debugfs_create_files':
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:1033:29: error: 
'VID_MODE_VPG_MODE' undeclared (first use in this function); did you mean 
'VID_MODE_VPG_ENABLE'?
    1033 |   REGISTER(vpg_ber_pattern, VID_MODE_VPG_MODE, dsi),
         |                             ^~~~~~~~~~~~~~~~~
   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:229:32: note: in definition of 
macro 'REGISTER'
     229 |  { #name, VPG_DEFS(name, dsi), mask, dsi }
         |                                ^~~~
   cc1: some warnings being treated as errors

vim +555 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

   531  
   532  static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi)
   533  {
   534          u32 val;
   535  
   536          /*
   537           * TODO dw drv improvements
   538           * enabling low power is panel-dependent, we should use the
   539           * panel configuration here...
   540           */
   541          val = ENABLE_LOW_POWER;
   542  
   543          if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
   544                  val |= VID_MODE_TYPE_BURST;
   545          else if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
   546                  val |= VID_MODE_TYPE_NON_BURST_SYNC_PULSES;
   547          else
   548                  val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS;
   549  
   550  #ifdef CONFIG_DEBUG_FS
   551          if (dsi->vpg_defs.vpg) {
   552                  val |= VID_MODE_VPG_ENABLE;
   553                  val |= dsi->vpg_defs.vpg_horizontal ?
   554                         VID_MODE_VPG_HORIZONTAL : 0;
 > 555                  val |= dsi->vpg_defs.vpg_ber_pattern ? 
 > VID_MODE_VPG_MODE : 0;
   556          }
   557  #endif /* CONFIG_DEBUG_FS */
   558  
   559          dsi_write(dsi, DSI_VID_MODE_CFG, val);
   560  }
   561  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to