AFBC helpers are available. Use those which increase code readability.

Signed-off-by: Andrzej Pietrasiewicz <andrze...@collabora.com>
---
 .../drm/arm/display/komeda/komeda_framebuffer.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
index 1b01a625f40e..f7edde3ac319 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
@@ -4,6 +4,7 @@
  * Author: James.Qian.Wang <james.qian.w...@arm.com>
  *
  */
+#include <drm/drm_afbc.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_gem.h>
@@ -52,20 +53,8 @@ komeda_fb_afbc_size_check(struct komeda_fb *kfb, struct 
drm_file *file,
                return -ENOENT;
        }
 
-       switch (fb->modifier & AFBC_FORMAT_MOD_BLOCK_SIZE_MASK) {
-       case AFBC_FORMAT_MOD_BLOCK_SIZE_32x8:
-               alignment_w = 32;
-               alignment_h = 8;
-               break;
-       case AFBC_FORMAT_MOD_BLOCK_SIZE_16x16:
-               alignment_w = 16;
-               alignment_h = 16;
-               break;
-       default:
-               WARN(1, "Invalid AFBC_FORMAT_MOD_BLOCK_SIZE: %lld.\n",
-                    fb->modifier & AFBC_FORMAT_MOD_BLOCK_SIZE_MASK);
-               break;
-       }
+       if (!drm_afbc_get_superblk_wh(fb->modifier, &alignment_w, &alignment_h))
+               return -EINVAL;
 
        /* tiled header afbc */
        if (fb->modifier & AFBC_FORMAT_MOD_TILED) {
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to