Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Expand comment in the 'vsps' parsing routine to specify the LIF > channel index defaults to 0 in case the second cell of the property > is not specified to remain compatible with older DT bindings.
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 7c9fb5860e54..186422ac552b 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -587,7 +587,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu) > > vsps[j].crtcs_mask |= BIT(i); > > - /* Store the VSP pointer and pipe index in the CRTC. */ > + /* > + * Store the VSP pointer and pipe index in the CRTC. If the > + * second cell of the 'vsps' specifier isn't present, default > + * to 0 to remain compatible with older DT bindings. > + */ > rcdu->crtcs[i].vsp = &rcdu->vsps[j]; > rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0; > } >
