Hi Noralf.
On Wed, Jul 17, 2019 at 01:58:13PM +0200, Noralf Trønnes wrote:
> This is only used by mipi-dbi drivers so move it there.
>
> The reason this isn't moved to the SPI subsystem is that it will in a
> later patch pass a dummy rx buffer for SPI controllers that need this.
> Low memory boards (64MB) can run into a problem allocating such a "large"
> contiguous buffer on every transfer after a long up time.
> This leaves a very specific use case, so we'll keep the function here.
> mipi-dbi will first go through a refactoring though, before this will
> be done.
>
> Remove SPI todo entry now that we're done with the tinydrm.ko SPI code.
>
> Additionally move the mipi_dbi_spi_init() declaration to the other SPI
> functions.
>
> Cc: David Lechner <da...@lechnology.com>
> Signed-off-by: Noralf Trønnes <nor...@tronnes.org>
With the few nitpics considered:
Reviewed-by: Sam Ravnborg <s...@ravnborg.org>
> diff --git a/include/drm/tinydrm/mipi-dbi.h b/include/drm/tinydrm/mipi-dbi.h
> index 51fc667beef7..576e9a7349ab 100644
> --- a/include/drm/tinydrm/mipi-dbi.h
> +++ b/include/drm/tinydrm/mipi-dbi.h
> @@ -67,8 +67,6 @@ static inline struct mipi_dbi *drm_to_mipi_dbi(struct
> drm_device *drm)
> return container_of(drm, struct mipi_dbi, drm);
> }
>
> -int mipi_dbi_spi_init(struct spi_device *spi, struct mipi_dbi *mipi,
> - struct gpio_desc *dc);
Moving this prototype looks like it belongs in another patch?
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
