On Tue, Jul 2, 2019 at 11:12 AM Rob Clark <robdcl...@gmail.com> wrote: > > On Tue, Jul 2, 2019 at 10:09 AM Jeffrey Hugo <jeffrey.l.h...@gmail.com> wrote: > > > > On Tue, Jul 2, 2019 at 9:46 AM Rob Clark <robdcl...@gmail.com> wrote: > > > > > > - dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > > > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > > > - MIPI_DSI_MODE_EOT_PACKET | > > > MIPI_DSI_MODE_VIDEO_HSE; > > > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO; > > > > Did you check this against the datasheet? Per my reading, EOT_PACKET > > and VIDEO_HSE appear valid. I don't know about VIDEO_SYNC_PULSE. > > The EOT flat is badly named: > > /* disable EoT packets in HS mode */ > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > I can double check out HSE, but this was one of the setting > differences between bootloader and kernel
Ah yeah, you are right. My eyes apparently skipped over the "disable". If the bootloader is not setting the HSE, then I can't think of a reason why we would be having an issue also not setting it. Seems good to me Reviewed-by: Jeffrey Hugo <jeffrey.l.h...@gmail.com>
