On Mon, Jun 24, 2019 at 1:32 PM Ilia Mirkin <imir...@alum.mit.edu> wrote:
>
> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu>
>
> One minor comment below though:
>
> (Maybe let it sit on the list for a day in case anyone feels like
> objecting strenuously.)

Thanks so much for the review!

> > @@ -829,6 +830,16 @@ connector_find_mode(struct device *dev, uint32_t 
> > con_id, const char *mode_str,
> >         if (!connector || !connector->count_modes)
> >                 return NULL;
> >
> > +       /* Pick by Index */
> > +       if (mode_str[0] == '#') {
> > +               int index = atoi(mode_str + 1);
> > +
> > +               if (index >= connector->count_modes)
>
> || index < 0

Ok, added this bit in my tree. I'll resubmit in a few days to let
others have a chance to review as well.

thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to