Hi Sam, Thanks for the good catch. Actually it's a typo in email reply. It should be 'len - 1'.
Regards, -----Original Message----- From: Sam Ravnborg <s...@ravnborg.org> Sent: Saturday, June 8, 2019 7:56 AM To: Zhang, Dingchen (David) <dingchen.zh...@amd.com> Cc: dri-devel@lists.freedesktop.org; Li, Sun peng (Leo) <sunpeng...@amd.com>; Wentland, Harry <harry.wentl...@amd.com> Subject: Re: [PATCH] drm: remove the newline for CRC source name. Hi Dingchen. Patch is much better now. On Fri, Jun 07, 2019 at 05:38:17PM -0400, Dingchen Zhang wrote: > userspace may transfer a newline, and this terminating newline is > replaced by a '\0' to avoid followup issues. > > 'n-1' is the index to replace the newline of CRC source name. I am a little confused where 'n' comes from here? I you had written ' len - 1' then there was a clear connection to the patch. With this fixed: Reviewed-by: Sam Ravnborg <s...@ravnborg.org> > > v2: update patch subject, body and format. (Sam) > > Cc: Leo Li <sunpeng...@amd.com> > Cc: Harry Wentland <harry.wentl...@amd.com> > Cc: Sam Ravnborg <s...@ravnborg.org> > Signed-off-by: Dingchen Zhang <dingchen.zh...@amd.com> > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c > b/drivers/gpu/drm/drm_debugfs_crc.c > index 585169f0dcc5..dac267e840af 100644 > --- a/drivers/gpu/drm/drm_debugfs_crc.c > +++ b/drivers/gpu/drm/drm_debugfs_crc.c > @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const > char __user *ubuf, > if (IS_ERR(source)) > return PTR_ERR(source); > > - if (source[len] == '\n') > - source[len] = '\0'; > + if (source[len - 1] == '\n') > + source[len - 1] = '\0'; > > ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt); > if (ret) > -- > 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
