Re: [PATCH 5/6] dt-bindings: Add ANX6345 DP/eDP transmitter binding

[Laurent Pinchart]

Hi Torsten,

Thank you for the patch.

On Thu, May 23, 2019 at 08:54:00AM +0200, Torsten Duwe wrote:
> From: Icenowy Zheng <icen...@aosc.io>
> 
> The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> for portable devices.
> 
> Add a binding document for it.
> 
> Signed-off-by: Icenowy Zheng <icen...@aosc.io>
> Signed-off-by: Vasily Khoruzhick <anars...@gmail.com>
> Reviewed-by: Rob Herring <r...@kernel.org>
> Signed-off-by: Torsten Duwe <d...@suse.de>

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> ---
>  .../bindings/display/bridge/anx6345.txt       | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/bridge/anx6345.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.txt 
> b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> new file mode 100644
> index 000000000000..e79a11348d11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> @@ -0,0 +1,56 @@
> +Analogix ANX6345 eDP Transmitter
> +--------------------------------
> +
> +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
> +portable devices.
> +
> +Required properties:
> +
> + - compatible                : "analogix,anx6345"
> + - reg                       : I2C address of the device
> + - reset-gpios               : Which GPIO to use for reset
> + - dvdd12-supply     : Regulator for 1.2V digital core power.
> + - dvdd25-supply     : Regulator for 2.5V digital core power.
> +
> +Optional properties:
> +
> + - Video ports for RGB input and eDP output using the DT bindings
> +   defined in [1]
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> +anx6345: anx6345@38 {
> +     compatible = "analogix,anx6345";
> +     reg = <0x38>;
> +     reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */
> +     dvdd25-supply = <&reg_dldo2>;
> +     dvdd12-supply = <&reg_fldo1>;
> +
> +     ports {
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             anx6345_in: port@0 {
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +                     reg = <0>;
> +                     anx6345_in_tcon0: endpoint@0 {
> +                             reg = <0>;
> +                             remote-endpoint = <&tcon0_out_anx6345>;
> +                     };
> +             };
> +
> +             anx6345_out: port@1 {
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +                     reg = <1>;
> +
> +                     anx6345_out_panel: endpoint@0 {
> +                             reg = <0>;
> +                             remote-endpoint = <&panel_in_edp>;
> +                     };
> +             };
> +     };
> +};

-- 
Regards,

Laurent Pinchart