On 16/04/2019 16:00, Yue Haibing wrote: > From: YueHaibing <yuehaib...@huawei.com> > > Fix sparse warning: > > drivers/gpu/drm/panfrost/panfrost_gem.c:17:6: > warning: symbol 'panfrost_gem_free_object' was not declared. Should it be > static? > > Reported-by: Hulk Robot <hul...@huawei.com> > Signed-off-by: YueHaibing <yuehaib...@huawei.com>
Reviewed-by: Steven Price <steven.pr...@arm.com> Although while we're fixing sparse warnings, there's a few more in Panfrost: -----8<------- From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001 From: Steven Price <steven.pr...@arm.com> Date: Wed, 17 Apr 2019 15:47:49 +0100 Subject: [PATCH] drm/panfrost: Add missing include Fix sparse warnings: drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5: warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static? drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6: warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static? drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6: warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static? drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6: warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static? Signed-off-by: Steven Price <steven.pr...@arm.com> --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index a8121ae67ee3..238bd1d89d43 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -7,6 +7,7 @@ #include <linux/regulator/consumer.h> #include "panfrost_device.h" +#include "panfrost_devfreq.h" #include "panfrost_features.h" #include "panfrost_issues.h" #include "panfrost_gpu.h" -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
