Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only

[Deepak Singh Rawat]

On Tue, 2019-04-16 at 09:42 +0200, Daniel Vetter wrote:
> On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> > user-space, so no point exposing it otherwise.
> > 
> > Signed-off-by: Deepak Rawat <dra...@vmware.com>
> > Fixes: d3b21767821e ("drm: Add a new plane property to send damage
> > during plane update")
> 
> Makes sense, probably good if we add Cc: sta...@vger.kernel.org too

Hi Daniel, thanks for the review. Sure.

> 
> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>
> 
> btw, want drm-misc commit rights to push this? Assuming you'd then
> push
> vmware drm patches in general ofc. See

Yes I think it would be a good idea if I can have drm-mics commit
rights. I think for occasional vmwgfx patches it would be ideal for us
to use drm-mics on the other hand if had some major changes better to
follow pull request way.

How to apply for drm-mics commit rights?

> 
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&amp;data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&amp;sdata=PMdonBtvx%2B2bMweQJTRu1b7IjmL0lSd2KKSIBV1ngTk%3D&amp;reserved=0
> 
> Cheers, Daniel
> 
> > ---
> >  drivers/gpu/drm/drm_mode_config.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_mode_config.c
> > b/drivers/gpu/drm/drm_mode_config.c
> > index 4a1c2023ccf0..1a346ae1599d 100644
> > --- a/drivers/gpu/drm/drm_mode_config.c
> > +++ b/drivers/gpu/drm/drm_mode_config.c
> > @@ -297,8 +297,9 @@ static int
> > drm_mode_create_standard_properties(struct drm_device *dev)
> >             return -ENOMEM;
> >     dev->mode_config.prop_crtc_id = prop;
> >  
> > -   prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
> > "FB_DAMAGE_CLIPS",
> > -                              0);
> > +   prop = drm_property_create(dev,
> > +                   DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> > +                   "FB_DAMAGE_CLIPS", 0);
> >     if (!prop)
> >             return -ENOMEM;
> >     dev->mode_config.prop_fb_damage_clips = prop;
> > -- 
> > 2.21.0
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&amp;sdata=QJCrLbtFUv7%2FiRAYOb2R%2Bab4w3l5CWae2K7t9Ya6dZw%3D&amp;reserved=0
> 
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel