Hi Andrey, On 03/04/2019 14:34, Tomi Valkeinen wrote: > On 02/04/2019 05:16, Andrey Smirnov wrote: > >> The early return above causes tc_get_display_props() to never be >> called for eDP case, which in turn result in tc_mode_valid() returning >> MODE_BAD for every mode it is given since it depends on tc->link.base >> being initialized properly. I had to change this code to: >> >> if (tc->hpd_num < 0) { >> if (!tc->panel) >> return connector_status_unknown; >> >> conn = true; >> } else { >> tc_read(GPIOI, &val); >> >> conn = val & BIT(tc->hpd_num); >> } >> >> to fix the problem. > > Ah, right. There's tc_get_display_props() in tc_bridge_enable() but > that's of course too late (and maybe even not needed at all). > > What you suggest here looks fine to me, so I'll change my patch > accordingly. Thanks!
With the change above, does the series work with your setup? Can I add your tested-by? I'll send v3 series soon with the DT change suggested by Rob and the above fix. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel