On Mon, Apr 01, 2019 at 10:17:18AM -0700, Douglas Anderson wrote: > From: Sean Paul <seanp...@chromium.org> > > This patch adds a new subnode to simple-panel allowing us to override > the typical timing expressed in the panel's display_timing. > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > > Cc: Doug Anderson <diand...@chromium.org> > Cc: Eric Anholt <e...@anholt.net> > Cc: Heiko Stuebner <he...@sntech.de> > Cc: Jeffy Chen <jeffy.c...@rock-chips.com> > Cc: Rob Herring <robh...@kernel.org> > Cc: Stéphane Marchesin <marc...@chromium.org> > Cc: Thierry Reding <thierry.red...@gmail.com> > Cc: devicet...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-rockc...@lists.infradead.org > Signed-off-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Douglas Anderson <diand...@chromium.org> > --- > > .../bindings/display/panel/simple-panel.txt | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > index b2b872c710f2..93882268c0b9 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -15,6 +15,16 @@ Optional properties: > (hot plug detect) signal, but the signal isn't hooked up so we should > hardcode the max delay from the panel spec when powering up the panel. > > +panel-timing subnode
Is there any reason why we need the panel- prefix? This is already part of a panel definition, so it's completely redundant. Why not just name the subnode "timing"? Thierry
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
