Re: [PATCH] drm/msm/a6xx: Fix build with !CONFIG_DEBUG_FS

[Mukesh Ojha]

On 4/3/2019 12:18 PM, Yue Haibing wrote:

From: YueHaibing <yuehaib...@huawei.com>

When building CONFIG_DEBUG_FS is not set
gcc warn this:

drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c: In function a6xx_show:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:1124:2: error: implicit declaration 
of function adreno_show; did you mean adreno_dump? 
[-Werror=implicit-function-declaration]
   adreno_show(gpu, state, p);
   ^~~~~~~~~~~

Reported-by: Hulk Robot <hul...@huawei.com>
Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state")
Signed-off-by: YueHaibing <yuehaib...@huawei.com>

Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>

Cheers,
-Mukesh

---
  drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c 
b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
index e686331..d327eb5 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
@@ -1121,7 +1121,9 @@ void a6xx_show(struct msm_gpu *gpu, struct msm_gpu_state 
*state,
        if (IS_ERR_OR_NULL(state))
                return;

+#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)

        adreno_show(gpu, state, p);
+#endif

drm_puts(p, "registers:\n");

        for (i = 0; i < a6xx_state->nr_registers; i++) {

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel