On Mon, Apr 1, 2019 at 8:07 AM Daniel Vetter <dan...@ffwll.ch> wrote: > > On Mon, Apr 1, 2019 at 9:47 AM Rob Herring <r...@kernel.org> wrote: > > > > Similar to the single handle drm_gem_object_lookup(), > > drm_gem_objects_lookup() takes an array of handles and returns an array > > of GEM objects. > > > > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > > Cc: Maxime Ripard <maxime.rip...@bootlin.com> > > Cc: Sean Paul <s...@poorly.run> > > Cc: David Airlie <airl...@linux.ie> > > Cc: Daniel Vetter <dan...@ffwll.ch> > > Signed-off-by: Rob Herring <r...@kernel.org> > > --- > > drivers/gpu/drm/drm_gem.c | 46 +++++++++++++++++++++++++++++++-------- > > include/drm/drm_gem.h | 2 ++ > > 2 files changed, 39 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > > index 388b3742e562..5c9bff45e5e1 100644 > > --- a/drivers/gpu/drm/drm_gem.c > > +++ b/drivers/gpu/drm/drm_gem.c > > @@ -663,6 +663,42 @@ void drm_gem_put_pages(struct drm_gem_object *obj, > > struct page **pages, > > } > > EXPORT_SYMBOL(drm_gem_put_pages); > > > > +/** > > + * drm_gem_objects_lookup - look up GEM objects from an array of handles > > + * @filp: DRM file private date > > + * @handle: pointer to array of userspace handle > > + * @count: size of handle array > > + * @objs: pointer to array of drm_gem_object pointers > > + * > > + * Returns: > > + * > > + * @objs filled in with GEM object pointers. -ENOENT is returned on a > > lookup > > + * failure. 0 is returned on success. > > Bonus points for adding references between the array and normal lookup > functions to guide people around. Also a comment that the buffers need > to be released with drm_gem_object_put(). > > > + */ > > +int drm_gem_objects_lookup(struct drm_file *filp, u32 *handle, int count, > > + struct drm_gem_object **objs) > > With a pointer to a pointer I'd expect this function to do the > allocation, but it doesn't. Normal pointer is enough to pass an array. > Also maybe make the handle pointer > const, so it's clear that it's an input parameter.
I thought about doing the allocation here, but then I couldn't implement the single drm_gem_object_lookup() using this function. Maybe I can refactor in 3 functions making this one a static function. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
