Daniel Vetter <dan...@ffwll.ch> writes: > On Wed, Feb 20, 2019 at 01:03:37PM -0800, Eric Anholt wrote: >> The debugfs_regset32 is nice to use for reducing boilerplate in >> dumping a bunch of regs in debugfs, but we also want to be able to >> print to dmesg them at runtime for driver debugging. drm_printer lets >> us format debugfs and the printk the same way. >> >> Signed-off-by: Eric Anholt <e...@anholt.net> >> --- >> drivers/gpu/drm/drm_print.c | 16 ++++++++++++++++ >> include/drm/drm_print.h | 2 ++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c >> index 0e7fc3e7dfb4..5ecc0f04cd0c 100644 >> --- a/drivers/gpu/drm/drm_print.c >> +++ b/drivers/gpu/drm/drm_print.c >> @@ -253,3 +253,19 @@ void drm_err(const char *format, ...) >> va_end(args); >> } >> EXPORT_SYMBOL(drm_err); >> + > > A bit of kerneldoc would be nice. With that: > > Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>
+/** + * drm_print_regset32 - print the contents of registers to a + * &drm_printer stream. + * + * @p: the &drm printer + * @regset: the list of registers to print. + * + * Often in driver debug, it's useful to be able to either capture the + * contents of registers in the steady state using debugfs or at + * specific points during operation. This lets the driver have a + * single list of registers for both. + */
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
