On Fri, Mar 15, 2019 at 11:46:20AM +1000, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > When Daniel removed struct_mutex he didn't fix this call to the unlocked > variant which is required since we no longer use struct mutex. > > This fixes a bunch of: > WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 > drm_gem_object_put+0x2b/0x30 [drm] > Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc > nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t> > CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2 > > backtraces when you plug in a udl device. > > Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage) > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Sean Paul <seanp...@chromium.org> > Signed-off-by: Dave Airlie <airl...@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > --- > drivers/gpu/drm/udl/udl_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c > index d5a23295dd80..bb7b58407039 100644 > --- a/drivers/gpu/drm/udl/udl_gem.c > +++ b/drivers/gpu/drm/udl/udl_gem.c > @@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device > *dev, > *offset = drm_vma_node_offset_addr(&gobj->base.vma_node); > > out: > - drm_gem_object_put(&gobj->base); > + drm_gem_object_put_unlocked(&gobj->base); > unlock: > mutex_unlock(&udl->gem_lock); > return ret; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
