On Tue, Mar 05, 2019 at 10:14:16AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Mar 04, 2019 at 12:06:01PM -0800, Eric Anholt wrote: > > > Since a change of the command line parser can pretty easily get things > > > wrong and introduce regressions, I also worked with a number of unit tests > > > that you can find here: http://code.bulix.org/tpo7dg-607264?raw > > > > Would kselftests be an appropriate way to include these, maybe? > > That looks like a good way to do this indeed. I'll try it and let you know
drm/selftests already has a pile of infrastructure, together with igt and will be run in intel-gfx-ci to make sure stuff keeps working. And yeah parser like this is imo the perfect selftest use-case. If you wonder about kselftest and kunit and all that: We have some compat glue, but I do hope that longterm we can all unify these internal self/unit tests under one framework. For now I recommend the drm one, since that's CI'ed. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
