Hi Jyri, Thank you for the patch.
On Thu, Feb 28, 2019 at 01:18:50PM +0200, Jyri Sarha wrote: > drm_fb_cma_get_gem_obj() may return NULL. The return value needs to be > checked before dereferencing the returned pointer. > > Signed-off-by: Jyri Sarha <jsa...@ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 1067e702c22c..a8ae064f52bb 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -75,6 +75,8 @@ static void set_scanout(struct drm_crtc *crtc, struct > drm_framebuffer *fb) > u64 dma_base_and_ceiling; > > gem = drm_fb_cma_get_gem_obj(fb, 0); > + if (WARN_ON(!gem)) > + return; But this should not happen, right ? Don't we have the required checks in place to ensure there will always be a valid GEM object available here ? > start = gem->paddr + fb->offsets[0] + > crtc->y * fb->pitches[0] + -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
