Bad EDID are a fact of life when dealing with random monitors. We only
spam the logs when debugging is enabled, but we only need to raise
notice and not set off the warning bells.

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
---
 drivers/gpu/drm/drm_edid.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 990b1909f9d7..98903cb7064d 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1535,9 +1535,8 @@ static void connector_bad_edid(struct drm_connector 
*connector,
        if (connector->bad_edid_counter++ && !(drm_debug & DRM_UT_KMS))
                return;
 
-       dev_warn(connector->dev->dev,
-                "%s: EDID is invalid:\n",
-                connector->name);
+       dev_notice(connector->dev->dev,
+                  "%s: EDID is invalid:\n", connector->name);
        for (i = 0; i < num_blocks; i++) {
                u8 *block = edid + i * EDID_LENGTH;
                char prefix[20];
@@ -1549,7 +1548,7 @@ static void connector_bad_edid(struct drm_connector 
*connector,
                else
                        sprintf(prefix, "\t[%02x] GOOD ", i);
 
-               print_hex_dump(KERN_WARNING,
+               print_hex_dump(KERN_NOTICE,
                               prefix, DUMP_PREFIX_NONE, 16, 1,
                               block, EDID_LENGTH, false);
        }
@@ -4695,8 +4694,8 @@ int drm_add_edid_modes(struct drm_connector *connector, 
struct edid *edid)
        }
        if (!drm_edid_is_valid(edid)) {
                clear_eld(connector);
-               dev_warn(connector->dev->dev, "%s: EDID invalid.\n",
-                        connector->name);
+               dev_notice(connector->dev->dev,
+                          "%s: EDID invalid.\n", connector->name);
                return 0;
        }
 
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to