Hi Laurent,
On 11/02/2019 11:46, Laurent Pinchart wrote:
> + /* Get the sampling edge from the endpoint. */
> + of_property_read_u32(ep, "pclk-sample", &pclk_sample);
> + of_node_put(ep);
> +
> + timings->input_bus_flags = DRM_BUS_FLAG_DE_HIGH;
> +
> + switch (pclk_sample) {
> + case 0:
> + timings->input_bus_flags |= DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
> + | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE;
> + break;
> + case 1:
> + timings->input_bus_flags |= DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE
> + | DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE;
> + break;
> + default:
> + return -EINVAL;
> + }
The default for pclk_sample is just the opposite of what omapdrm's
tfp410 used to do. The dts doc file also says that pclk-sample is
required, but the driver works fine without it, defaulting to 0.
This means that none of the omap dts files with tfp410 work correctly,
instead they silently use the wrong settings which may work but easily
also won't...
As the bus flags are added in this patch for the first time, maybe we
can assume that no one is using them, and the default could be made to
be the same as was on omapdrm's tfp410?
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
