On Fri, Feb 22, 2019 at 10:54:21AM +0100, Daniel Vetter wrote:
> > - idr_alloc() returned -ENOSPC, radix_tree_insert() returned -EEXIST.
> > xa_insert() and xa_alloc() return -EBUSY.
>
> I think this will upset a few of our tests. Just written some more for
> drm-lease at least, and those check for the ENOSPC. Not sure yet what to
> do.
If there's real userspace (not just a test suite) which actually relies
on the exact errno returned, we can change the places which currently
just return the errno to something like:
if (err == -EBUSY)
return -ENOSPC;
return err;
There are actually a number of places in the kernel which do the opposite
translation today, presumably because having a program print out "No
space left on device" was confusing.
If it's only the test-suite which cares, presumably the test suite can
be changed to treat EBUSY and ENOSPC as being equivalent errno values
for a given test.
> I did at least read the above, I'll leave all the driver patches for
> others. At least for now, any leftovers can be smashed into drm-misc.
Thanks! I'll resend after -rc1.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
