Hi, the original version was sent 14.04.2018: https://patchwork.kernel.org/patch/10344403/
Changes since then: - rebased on currentl drm/next The reset value of the register is 0, the soft reset does not reset this register and if other kernel changed this the audio is going to be distorted. It was observed when - accidentally - booted the kernel from eMMC on BBB which is 3.8.13-bone79 and it sets this register to 0x0a. After reboot and tda998x_reset() it remains 0x0a. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 7f34601bb515..72f93802d209 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -722,6 +722,9 @@ tda998x_reset(struct tda998x_priv *priv) /* Write the default value MUX register */ reg_write(priv, REG_MUX_VP_VIP_OUT, 0x24); + + /* Write the default to I2S_FORMAT register */ + reg_write(priv, REG_I2S_FORMAT, 0x00); } /* -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel