Hi David,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.0-rc4 next-20190221]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/David-Santamar-a-Rogado/drm-panel-orientation-quirks-Get-rid-of-superfluous-void-casting/20190222-044326
config: i386-randconfig-x019-201907 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_panel_orientation_quirks.c:89:18: warning: 
>> initialization discards 'const' qualifier from pointer target type 
>> [-Wdiscarded-qualifiers]
      .driver_data = &acer_s1003,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:95:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &asus_t100ha,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:108:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &gpd_pocket,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:116:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &gpd_win,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:124:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &gpd_win2,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:132:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &itworks_tw891,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:143:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &lcd800x1280_rightside_up,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:150:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &lcd800x1280_rightside_up,
                     ^
   drivers/gpu/drm/drm_panel_orientation_quirks.c:156:18: warning: 
initialization discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
      .driver_data = &lcd800x1280_rightside_up,
                     ^

vim +/const +89 drivers/gpu/drm/drm_panel_orientation_quirks.c

    82  
    83  static const struct dmi_system_id orientation_data[] = {
    84          {       /* Acer One 10 (S1003) */
    85                  .matches = {
    86                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
    87                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
    88                  },
  > 89                  .driver_data = &acer_s1003,
    90          }, {    /* Asus T100HA */
    91                  .matches = {
    92                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER 
INC."),
    93                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
    94                  },
    95                  .driver_data = &asus_t100ha,
    96          }, {    /*
    97                   * GPD Pocket, note that the the DMI data is less 
generic then
    98                   * it seems, devices with a board-vendor of "AMI 
Corporation"
    99                   * are quite rare, as are devices which have both 
board- *and*
   100                   * product-id set to "Default String"
   101                   */
   102                  .matches = {
   103                    DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
   104                    DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
   105                    DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
   106                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
   107                  },
   108                  .driver_data = &gpd_pocket,
   109          }, {    /* GPD Win (same note on DMI match as GPD Pocket) */
   110                  .matches = {
   111                    DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
   112                    DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
   113                    DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
   114                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
   115                  },
   116                  .driver_data = &gpd_win,
   117          }, {    /* GPD Win 2 (too generic strings, also match on bios 
date) */
   118                  .matches = {
   119                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
   120                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
   121                    DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
   122                    DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
   123                  },
   124                  .driver_data = &gpd_win2,
   125          }, {    /* I.T.Works TW891 */
   126                  .matches = {
   127                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by 
O.E.M."),
   128                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "TW891"),
   129                    DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by 
O.E.M."),
   130                    DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
   131                  },
   132                  .driver_data = &itworks_tw891,
   133          }, {    /*
   134                   * Lenovo Ideapad Miix 310 laptop, only some production 
batches
   135                   * have a portrait screen, the resolution checks makes 
the quirk
   136                   * apply only to those batches.
   137                   */
   138                  .matches = {
   139                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
   140                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
   141                    DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 
310-10ICR"),
   142                  },
   143                  .driver_data = &lcd800x1280_rightside_up,
   144          }, {    /* Lenovo Ideapad Miix 320 */
   145                  .matches = {
   146                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
   147                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
   148                    DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 
320-10ICR"),
   149                  },
   150                  .driver_data = &lcd800x1280_rightside_up,
   151          }, {    /* VIOS LTH17 */
   152                  .matches = {
   153                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
   154                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
   155                  },
   156                  .driver_data = &lcd800x1280_rightside_up,
   157          },
   158          {}
   159  };
   160  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to